Conversation
1 task
sonms
approved these changes
Nov 3, 2025
Member
sonms
left a comment
sonms
left a comment
There was a problem hiding this comment.
너무너무 고생하셨습니다~ 바쁘신데 너무 고마워요 사랑해요 우리형
app/src/main/AndroidManifest.xml
Outdated
| xmlns:tools="http://schemas.android.com/tools"> | ||
|
|
||
| <uses-permission android:name="android.permission.INTERNET"/> | ||
| <uses-permission android:name="android.permission.GET_ACCOUNTS"/> |
Member
There was a problem hiding this comment.
이거 추가한 이유있을까요? 구글 로그인 만이면 굳이 핸드폰 자체의 계정까지 가져오지 않아도 되고 GoogleSignInClient으로 대체된 것으로 알아요
Member
Author
There was a problem hiding this comment.
앗 초기에 구글 로그인 연동 때, 오류 나서 이것 저것 시도했던 흔적이.. 남아 있네요. Client id 문제였던걸로 해결됐으니, 삭제하겠습니다!
| suspendRunCatching { | ||
| val googleIdOption = GetGoogleIdOption.Builder() | ||
| .setFilterByAuthorizedAccounts(false) | ||
| .setAutoSelectEnabled(false) |
Member
Author
There was a problem hiding this comment.
이것도 위와 같은 이유인데, 등록된 계정만 가능할 수 있게? 해준다해서 세팅하다가.. 다시 돌려놓겠습니다
| onEmailChanged = viewModel::onEmailChanged, | ||
| onPasswordChanged = viewModel::onPasswordChanged, | ||
| onClickIcon = viewModel::onPasswordVisibilityChanged, | ||
| onClick = {}, |
| .padding(top = 80.dp) | ||
| .padding(horizontal = 16.dp) | ||
| .imePadding() | ||
| modifier = modifier |
Comment on lines
+145
to
+148
| Image( | ||
| painter = painterResource(R.drawable.img_login_sub), | ||
| contentDescription = stringResource(R.string.ic_login_sub_image), | ||
| ) |
Member
There was a problem hiding this comment.
이거 figma보다 너무 작은 거 같은데 크기 확인또는 onGloballyPositioned 를 통해 위치를 조정하거나 크기를 좀더 키워봅시다~~! 안되면 디자인팀 쪼기 ㄱㄱ
| logo = R.drawable.ic_login_kakao, | ||
| loginText = stringResource(R.string.ic_login_kakao), | ||
| onClick = onClick, | ||
| modifier = modifier |
| }, | ||
| ) | ||
| } | ||
| modifier = modifier |
Comment on lines
184
to
+188
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(horizontal = 16.dp, vertical = 24.dp) | ||
| .navigationBarsPadding() | ||
| .padding(bottom = 60.dp) | ||
| ) { | ||
| /* PawkeyButton( | ||
| text = "신규 계정으로 회원가입", | ||
| onClick = navigateUp, | ||
| enabled = true, | ||
| isBackGround = true, | ||
| isBorder = false, | ||
| modifier = Modifier.fillMaxWidth() | ||
| )*/ | ||
|
|
||
| Spacer(modifier = Modifier.height(12.dp)) | ||
|
|
||
| PawkeyButton( | ||
| text = "로그인", | ||
| onClick = navigateNext, | ||
| enabled = isLoginFormValid, | ||
| modifier = Modifier.fillMaxWidth() | ||
| ) | ||
| } | ||
| .size(370.dp) | ||
| .align(Alignment.CenterEnd) | ||
| .offset(x = 70.dp), | ||
| ) |
Member
There was a problem hiding this comment.
contentScale = ContentScale.Crop,
//또는
BoxWithConstraints(modifier = Modifier.fillMaxSize()) {
val imageSize = maxWidth * 0.5f // 부모 가로의 50% 크기로 설정
Image(
painter = painterResource(R.drawable.img_login_main),
contentDescription = null,
modifier = Modifier
.size(imageSize)
.align(Alignment.CenterEnd)
)
}이런식으로 해서 size와 offset을 피해봅시다ㅏ
Comment on lines
59
to
64
| fun onEmailChanged(email: String) { | ||
| _state.value = _state.value.copy(email = email) | ||
| } | ||
|
|
||
| fun onPasswordChanged(password: String) { | ||
| _state.value = _state.value.copy( | ||
| password = password | ||
| ) | ||
| _state.value = _state.value.copy(password = password) |
| contentScale = ContentScale.FillBounds | ||
| modifier = Modifier | ||
| .align(alignment = Alignment.Center) | ||
| .size(360.dp), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE
❗ WORK DESCRIPTIONAdd commentMore actions
📸 SCREENSHOT
-.Clipchamp.5.mp4